WiFiSetupPage never showed networks and could not be exited once entered.
Several compounding bugs were responsible across network.go and page.go.
Primary bugs fixed:
- WiFiSetupPage.Init() never assigned p.wifiDevice after FindDevices(),
so startScan() always hit the nil guard and exited without launching
a scan goroutine. No networks ever appeared in the list. A value copy
of the Wi-Fi device is now taken from m.Devices immediately after
FindDevices() returns, with an explicit error if no adapter is found.
- CheckInternetConnection() called FindDevices() on every tick, rebuilding
m.Devices every 2 seconds. This caused [NET-030] log spam, invalidated
any pointers held into the slice, and meant checkState()'s fresh Manager
instances (which have an empty Devices slice) would never detect internet
after Fix 2 was applied. CheckInternetConnection() now calls FindDevices()
only when m.Devices is empty (fresh Manager), and does a cheaper per-device
State property refresh when devices are already known (long-lived Manager).
This satisfies both callers correctly.
- Connect() called WaitForInternet(30s, 5s) synchronously before returning,
blocking the main UI thread for up to 35 seconds. It also returned an error
if internet wasn't stable in time, even though AddAndActivateConnection had
succeeded, causing the page to show "Failed to initiate connection" while NM
was still negotiating in the background. WaitForInternet removed from
Connect(); the page's existing checkConnectionStatusLoop and
handleConnectionStatusUpdate already handle post-connection state tracking.
Additional bugs fixed:
- startScan() launched a new StartScan goroutine on every R-press without
signalling the previous one to stop. Concurrent goroutines raced on
resultsChan and accumulated indefinitely. stopScan is now closed and
replaced before each scan, and checkConnectionStatusLoop is restarted
with the new channel.
- Connect() always generated a new UUID and called AddAndActivateConnection
without checking for an existing profile. Repeated connection attempts
(e.g. wrong password then correct) accumulated duplicate stale profiles
in NetworkManager. Existing profiles matching the SSID are now deleted
via Settings.Connection.Delete before creating a new one.
- m.Devices was read and written concurrently from StartScan and
CheckInternetConnection goroutines without synchronisation. A sync.RWMutex
is added to Manager; state refreshes take a write lock, StartScan device
lookup takes a read lock.
- Connect() checked wifiDevice.State using the caller's value copy taken at
Init() time, which never updated. The current state is now read from
m.Devices under lock at the point of connection.
- auth-alg: "open" was unconditionally set in the 802-11-wireless-security
settings block. This field is only meaningful for WPA/WPA2-Personal and
should be omitted for SAE (WPA3) and EAP variants. It is now only set
when KeyMgmt is "wpa-psk".
Database is more usable now.
All pages have been updated to use the database, and share an application configuration.
Page Stack has been removed, no more pages hanging around in memory. Replaced with a 'Router' which uses an Enum to determine which page should be displayed, destroys the old page and initializes the new page all in one go. No more push, pop, rollback, etc. No more holding instances of pages.
Logger has been updated with proper timestamps and sorting now works as expected."
The kiosk lacks an input method framework, so SDL2 never generates
TextInputEvent. The WiFi password page already had a keycodeToChar
fallback but email and license key pages did not — characters were
never appended to inputText. Also removes excessive debug logging
from the previous commit.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NeilClack