3 Commits
Author SHA1 Message Date
NeilClack 400c6a782b Scroller: use full window height on rotated/tall displays
build-dev / nix-build (push) Successful in 41s
Override the LETTERBOX logical presentation while the scroller is
active so it renders into the full physical window.  On a 1920x6480
rotated display the scroller now scrolls through all 6480 pixels of
vertical space instead of being confined to the 1920x1080 letterbox
region.  Text scale is unchanged (same font size, same pixel
rasterization); more lines are simply visible at once.

- onPush: save current logical presentation, switch to DISABLED with
  real window dimensions
- onPop: restore the saved LETTERBOX presentation
- resize handler in main.cpp: skip re-apply while scroller is active
  (it owns its own presentation and restores on pop)
2026-08-25 10:55:53 -05:00
NeilClack 9b0bd517c6 pad footer 2026-08-25 10:33:04 -05:00
NeilClack babb74c7ad Fix attic upload
build-dev / nix-build (push) Successful in 40s
2026-08-25 07:55:32 -05:00
5 changed files with 65 additions and 19 deletions
+13 -5
View File
@@ -41,10 +41,17 @@ jobs:
# checks is keyed per-system (checks.<system>.default); nix build's # checks is keyed per-system (checks.<system>.default); nix build's
# #attr shorthand can't resolve it, so resolve the current system inline. # #attr shorthand can't resolve it, so resolve the current system inline.
# --impure lets the flake read APP_VERSION via builtins.getEnv # --impure lets the flake read APP_VERSION via builtins.getEnv
# (pure evals always get the package defaults). The offline test suite # (pure evals always get the package defaults).
# runs in the package's checkPhase. - name: Build package
run: |
nix build -L ".#packages.$(nix eval --impure --raw --expr 'builtins.currentSystem').default" \
--impure --out-link result-pkg
# The offline test suite runs in the check derivation's checkPhase.
# This is a separate build/output from the package itself.
- name: Build + offline test suite - name: Build + offline test suite
run: nix build -L ".#checks.$(nix eval --impure --raw --expr 'builtins.currentSystem').default" --impure run: |
nix build -L ".#checks.$(nix eval --impure --raw --expr 'builtins.currentSystem').default" \
--impure --out-link result-checks
- name: Live portal tests - name: Live portal tests
env: env:
@@ -59,10 +66,11 @@ jobs:
./build/test_license_service ./build/test_license_service
' '
# Release closure lands in the release cache. # Release closure (the actual package, not the check output) lands in the
# release cache.
- name: Push to Attic release cache - name: Push to Attic release cache
env: env:
ATTIC_TOKEN: ${{ secrets.ATTIC_TOKEN_PROD }} ATTIC_TOKEN: ${{ secrets.ATTIC_TOKEN_PROD }}
run: | run: |
attic login radiantwave https://attic.radiantwavetech.com "$ATTIC_TOKEN" attic login radiantwave https://attic.radiantwavetech.com "$ATTIC_TOKEN"
attic push radiantwave:radiantwave ./result attic push radiantwave:radiantwave ./result-pkg
+2 -2
View File
@@ -281,10 +281,10 @@ void Home::render(SDL_Renderer *renderer)
fourSpaces.destroy(); fourSpaces.destroy();
const float margin = 20.0f; const float margin = 20.0f;
float rectRight = fw - margin; float rectRight = fw - margin - 50.0f;
float rectLeft = rectRight - (maxNameW + spaceW4 + maxValueW); float rectLeft = rectRight - (maxNameW + spaceW4 + maxValueW);
float lineY = fh - margin; float lineY = fh - margin - 50.0f;
const float lineGap = 6.0f; const float lineGap = 6.0f;
for (size_t i = footerNames_.size(); i-- > 0;) for (size_t i = footerNames_.size(); i-- > 0;)
{ {
+6 -1
View File
@@ -7,6 +7,7 @@
#include "logical_size.h" #include "logical_size.h"
#include "logger/logger.h" #include "logger/logger.h"
#include "provisioning.h" #include "provisioning.h"
#include "scroller_page.h"
namespace { namespace {
// How long audio fades out before the app tears down on quit. Only applied // How long audio fades out before the app tears down on quit. Only applied
@@ -201,12 +202,16 @@ SDL_AppResult SDL_AppEvent(void *appstate, SDL_Event *event) {
std::to_string(event->window.data1) + "x" + std::to_string(event->window.data1) + "x" +
std::to_string(event->window.data2)); std::to_string(event->window.data2));
// Logical presentation persists across resizes; re-apply defensively // Logical presentation persists across resizes; re-apply defensively
// in case backend state was reset underneath us. // in case backend state was reset underneath us. Skip while the
// scroller is active — it owns its own presentation (NONE, full
// window) and restores LETTERBOX in onPop.
if (!dynamic_cast<ScrollerPage *>(state.pages.current())) {
SDL_SetRenderLogicalPresentation(state.renderer, SDL_SetRenderLogicalPresentation(state.renderer,
radiantwave::kDesignWidth, radiantwave::kDesignWidth,
radiantwave::kDesignHeight, radiantwave::kDesignHeight,
SDL_LOGICAL_PRESENTATION_LETTERBOX); SDL_LOGICAL_PRESENTATION_LETTERBOX);
} }
}
if (!state.keybinds.handleEvent(*event)) { if (!state.keybinds.handleEvent(*event)) {
state.pages.handleEvent(*event); state.pages.handleEvent(*event);
+36 -7
View File
@@ -34,13 +34,37 @@ void ScrollerPage::onPush(AppState &state)
{ {
state_ = &state; state_ = &state;
int winW = 0; // Save the current logical presentation (LETTERBOX at design resolution)
int winH = 0; // and switch to NONE so we render into the full physical window. This
radiantwave::getLayoutSize(state.renderer, &winW, &winH); // lets the scroller scroll the entire vertical extent of tall/rotated
screenW_ = static_cast<float>(winW); // displays while keeping text at the same pixel scale. onPop restores
screenH_ = static_cast<float>(winH); // the original presentation for other pages.
// Lines are capped at the full screen width; the widest Fibonacci lines are SDL_GetRenderLogicalPresentation(state.renderer, &savedLogicalW_,
// sized to fill it with whole words (peak word count derived from the &savedLogicalH_, &savedMode_);
SDL_Window *window = SDL_GetRenderWindow(state.renderer);
int windowW = 0;
int windowH = 0;
if (window)
{
SDL_GetWindowSize(window, &windowW, &windowH);
}
if (windowW <= 0)
{
windowW = radiantwave::kDesignWidth;
}
if (windowH <= 0)
{
windowH = radiantwave::kDesignHeight;
}
SDL_SetRenderLogicalPresentation(state.renderer, windowW, windowH,
SDL_LOGICAL_PRESENTATION_DISABLED);
screenW_ = static_cast<float>(windowW);
screenH_ = static_cast<float>(windowH);
// Lines are capped at the full screen width; the widest Fibonacci lines
// are sized to fill it with whole words (peak word count derived from the
// screen), independent of resolution. // screen), independent of resolution.
maxLineWidth_ = screenW_; maxLineWidth_ = screenW_;
@@ -101,6 +125,11 @@ void ScrollerPage::onPause(AppState &state)
void ScrollerPage::onPop(AppState &state) void ScrollerPage::onPop(AppState &state)
{ {
// Restore the original logical presentation so other pages (Home,
// Settings, etc.) render in the design-resolution LETTERBOX space.
SDL_SetRenderLogicalPresentation(state.renderer, savedLogicalW_,
savedLogicalH_, savedMode_);
state.audio.stopTrackFadeOut(kFadeSeconds); state.audio.stopTrackFadeOut(kFadeSeconds);
state.keybinds.unbindAll(); state.keybinds.unbindAll();
destroyResources(); destroyResources();
+4
View File
@@ -115,4 +115,8 @@ private:
float velocityDelay_ = 2.5f; float velocityDelay_ = 2.5f;
int velocityState_ = 0; int velocityState_ = 0;
float velocityTimer_ = 0.0f; float velocityTimer_ = 0.0f;
int savedLogicalW_ = 0;
int savedLogicalH_ = 0;
SDL_RendererLogicalPresentation savedMode_ = SDL_LOGICAL_PRESENTATION_DISABLED;
}; };