Primary fix: checkState() now detects when both old and new states map
to the HOME page (DOWNLOADING_ASSETS and READY) and skips re-navigation.
This prevents destroying and recreating the Home page, which would
close the already-closed DownloadDone channel.
Defense-in-depth: Home.downloadDone flag prevents close if a new Home
page somehow reaches the close path.
12 application tests, 4 page tests, 18 mixer tests (34 total).
Tests cover: prerequisite priority ordering, state blocking on
downloads, non-blocking channel read, double-close guard, download
failure path, and repeated computeState calls.
When transitioning from DOWNLOADING_ASSETS to READY, checkState()
re-navigates to HOME. The new Home page sees the already-closed
MessageChannel and tries to close DownloadDone again, causing a
panic that restarts the process.
Guard the close with a downloadDone bool field on Home.
F2 (scroller) and F3 (settings) now work while audio downloads are in
progress. Only blocked during early prerequisites: no wifi, no email,
no license key.
network.init() no longer panics when D-Bus is unavailable (logs warning
instead). This allows go test to run in the nix build sandbox.
checkState() now calls computeState() which returns the target state
without triggering page navigation (which requires OpenGL). Tests call
computeState() directly, avoiding the SIGSEGV from gl.GenVertexArrays.
7 regression tests for state machine, all passing.
State machine now uses DOWNLOADING_ASSETS before READY. Downloads closing
the DownloadDone channel signals checkState() to proceed. Download failure
sets downloadFailed flag which prevents READY. Audio files moved from
~/.local/share/rhemawave/audio to ~/.radiantwave/audio/.
Regression tests in application_test.go (linux build-tagged due to
network package D-Bus init). Version 0.6.
- SwitchDevice volume silently zeroed: Init uses cfg.SavedVolume,
SwitchDevice restores saved volume after reopening device
- SwitchDevice not persisted to database: caller saves SelectedAudioDevice
- Device restore passes invalid 'system default' to SDL: now passes ''
- Stop() no-op when audio toggled off: removed AudioEnabled guard
Regression tests added for all 4 bugs. CI now runs go test before build.
Play() held mu then called SwitchDevice() which also tried to acquire mu,
causing a deadlock. Replace with direct call to openDeviceLocked() which
does not lock.
Add regression test that verifies Play() returns an error (not deadlock)
when called on an uninitialized mixer.
Remove dead 'currentVolume' variable that was never written to, causing
SwitchDevice to always restore volume to 0 after switching audio devices.
- Remove currentVolume from package state
- SwitchDevice now sets mix.MAX_VOLUME after reopening device
- GetVolume128 now queries SDL directly instead of reading stale variable
- Fix parseSinkLine not stripping trailing ']' from [vol: X.XX] (caused
volume to silently parse as 0 for sinks without MUTED tag)
- Fix flake.nix: make wayland/X11 buildInputs Linux-only for macOS compat
- Add unit tests for parseSinks, parseSinkLine, and ConvertVolume
- Add changelog.txt tracking all audio bug fixes
Remove dead 'currentVolume' variable that was never written to, causing
SwitchDevice to always restore volume to 0 after switching audio devices.
- Remove currentVolume from package state
- SwitchDevice now sets mix.MAX_VOLUME after reopening device
- GetVolume128 now queries SDL directly instead of reading stale variable
- Add unit tests for parseSinks, parseSinkLine, and ConvertVolume
- Add changelog.txt tracking all audio bug fixes
- Fixed detectSecurity() where WPA2 (0x100/PSK) and WPA3 (0x400/SAE)
flags were swapped, causing NM to reject connections silently
- Added missing AP path to AddAndActivateConnection call
- Added critical connection settings: UUID, interface-name,
autoconnect, permissions
- Changed init() to fail fast with logger.Fatal instead of
silent failure on NM connection error
- Added auth-alg and psk-flags to WPA/WPA2 security settings
Replace in-memory atomic AppConfig caching with direct DB queries via db.GetConfig
across application and page layers. This simplifies state management and ensures
all components always operate on the latest persisted configuration.
Key changes:
- Remove Application.Config atomic cache and refreshCache mechanism
- Eliminate PageCtx.CfgPtr and pass DB handle instead
- Replace all cfg reads with db.GetConfig(app.DB)
- Update mixer, audio, UI pages, and initialization paths accordingly
- Explicitly set AppConfig table name to avoid GORM pluralization issues
- Reduce DB connection pooling (SetMaxIdleConns(1))
- Standardize application font to SpaceMonoNerdFont-Regular
- Lower default audio volume (1.0 → 0.2)
- Add Unicode checkmark glyph to font map
Behavioral impact:
- Configuration is no longer cached in memory
- Every config access now hits the DB (more consistent, slightly more overhead)
WiFiSetupPage never showed networks and could not be exited once entered.
Several compounding bugs were responsible across network.go and page.go.
Primary bugs fixed:
- WiFiSetupPage.Init() never assigned p.wifiDevice after FindDevices(),
so startScan() always hit the nil guard and exited without launching
a scan goroutine. No networks ever appeared in the list. A value copy
of the Wi-Fi device is now taken from m.Devices immediately after
FindDevices() returns, with an explicit error if no adapter is found.
- CheckInternetConnection() called FindDevices() on every tick, rebuilding
m.Devices every 2 seconds. This caused [NET-030] log spam, invalidated
any pointers held into the slice, and meant checkState()'s fresh Manager
instances (which have an empty Devices slice) would never detect internet
after Fix 2 was applied. CheckInternetConnection() now calls FindDevices()
only when m.Devices is empty (fresh Manager), and does a cheaper per-device
State property refresh when devices are already known (long-lived Manager).
This satisfies both callers correctly.
- Connect() called WaitForInternet(30s, 5s) synchronously before returning,
blocking the main UI thread for up to 35 seconds. It also returned an error
if internet wasn't stable in time, even though AddAndActivateConnection had
succeeded, causing the page to show "Failed to initiate connection" while NM
was still negotiating in the background. WaitForInternet removed from
Connect(); the page's existing checkConnectionStatusLoop and
handleConnectionStatusUpdate already handle post-connection state tracking.
Additional bugs fixed:
- startScan() launched a new StartScan goroutine on every R-press without
signalling the previous one to stop. Concurrent goroutines raced on
resultsChan and accumulated indefinitely. stopScan is now closed and
replaced before each scan, and checkConnectionStatusLoop is restarted
with the new channel.
- Connect() always generated a new UUID and called AddAndActivateConnection
without checking for an existing profile. Repeated connection attempts
(e.g. wrong password then correct) accumulated duplicate stale profiles
in NetworkManager. Existing profiles matching the SSID are now deleted
via Settings.Connection.Delete before creating a new one.
- m.Devices was read and written concurrently from StartScan and
CheckInternetConnection goroutines without synchronisation. A sync.RWMutex
is added to Manager; state refreshes take a write lock, StartScan device
lookup takes a read lock.
- Connect() checked wifiDevice.State using the caller's value copy taken at
Init() time, which never updated. The current state is now read from
m.Devices under lock at the point of connection.
- auth-alg: "open" was unconditionally set in the 802-11-wireless-security
settings block. This field is only meaningful for WPA/WPA2-Personal and
should be omitted for SAE (WPA3) and EAP variants. It is now only set
when KeyMgmt is "wpa-psk".
NeilClack